Skip to content

Feature/physics carry iteration#43

Merged
jeshernandez merged 3 commits intomainfrom
feature/physics-carry-iteration
Mar 16, 2026
Merged

Feature/physics carry iteration#43
jeshernandez merged 3 commits intomainfrom
feature/physics-carry-iteration

Conversation

@jeshernandez
Copy link
Copy Markdown
Contributor

Description

  • Updating addon documentation

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Physics tuning (changes to rollout/aerodynamic parameters)
  • Documentation update
  • Test improvements

Physics Changes (if applicable)

Modified Parameters

  • Velocity scaling curve
  • Spin multiplier curve
  • COR (Coefficient of Restitution)
  • Surface friction coefficients
  • Aerodynamic coefficients (Cd/Cl)

Test Results

Chip shot:    X.X / X.X yd  (baseline: 7.6/13.1 yd, target: 13.0 yd)
Bump shot:    X.X / X.X yd  (baseline: 38.1/89.7 yd, target: 85 yd)
Wood shot:    X.X / X.X yd  (baseline: 121.7/194.7 yd, target: 198 yd)
Approach shot: X.X / X.X yd  (baseline: 105.6/108.3 yd, target: 108 yd)

Formula Tests

  • Rollout physics tests passing: dotnet test --filter "Category=RolloutPhysics"
  • Updated test expected values (if formulas changed)
  • Updated regression baselines in ShotDistanceRegressionTests.cs

Testing Checklist

  • All tests pass locally: dotnet test OpenFairway.sln
  • Rollout physics formula tests pass: dotnet test --filter "Category=RolloutPhysics"
  • Code builds without errors: dotnet build OpenFairway.sln
  • Tested in Godot editor (if applicable)
  • Manual testing performed (describe in comments below)

Code Quality

  • Code follows project conventions (PascalCase for public, _camelCase for private)
  • Added/updated XML documentation comments for public APIs
  • No compiler warnings introduced
  • Code formatted with dotnet format (will be checked by CI)

Additional Notes

Related Issues

Closes #

@jeshernandez jeshernandez merged commit 4f3e11b into main Mar 16, 2026
5 checks passed
@jeshernandez jeshernandez deleted the feature/physics-carry-iteration branch March 16, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant